couldn't map PC to fn error after container removes itself

realmsandruins

Does the issue occur in the editor or during gameplay? If it occurs during gameplay, please specify which movement system is being used (free movement or grid movement):
Gameplay, grid movement.

Briefly describe the issue you're experiencing:
When a container removes self, the game crashes when you try to save.

Are there any errors in the in-game debug console or external console window?
Yes, attached.

Provide the steps necessary to reproduce the issue:
Create a container that script
removes self on close if the player loots the item, then try to save. Close script as follows:

if player.inventory contains "ITEM_0001" then
remove_entity(self);
end;

Provide a download link to the bare bones project (if applicable):

Justin

realmsandruins Thanks for the report! The project download link seems to be no longer working, would you mind updating that when you get a chance? I'll try to take a look at it for the next update.

barron

i get this error also so far i have it when I'm interacting with my item containers that have a wait timer in my case disabling and then a wait then enable a container the script apparently even carry's on with the wait and continues the script even if i leave the map with that set up then i get the same error and closes the game

realmsandruins

Confirmed this still occurs in v1.1

Slayer

realmsandruins This also happens if you just open a container, close it, and remove it via ingame console.
not via close script, but just any time after opening it.

I suspect this may very well be tied to how containers work in regards to the widgets.
If a container no longer exists but a widget is "in memory" that holds the items of that container, when you save, it goes into a crash loop.
(if you were to type "show_widget(container_widget_name)" in console, you'd see the items are still there despite removing the container).

Of course, that's just my guess, I don't know what the engineis doing behind the scenes lol but I do know that widgets used for containers remember the last items accessed...(how widgets tied to containers get assigned/populated when you interact with one) and if that container has just been removed...that could be where the crash comes from.

A good way to test/prove this is to place two containers in a map with the same widget, access one, access two, delete one and save.....does it crash?

This is why personally advise if you want to do anything more advanced with containers besides just open and close them, but script them/remove them, best to not do those to the actual container, but an object that references the container instead.

Slayer

Just a follow up:

I ran the suggested test and can confim...

if two containers are set to the same widget, and you interact with both #1 and #2, remove #1 (one you opened first), you can save fine without a crash.

Because, by then, the "in memory" widget for that container (#1) has been overriden with items/settings of a container still on the map (#2).

EDIT:

To follow on even further, running some other tests, this looks to specifically be the title of the widget.
If you null all the items in the widget after removing the container, before saving, it still crashes.
Same with if you empty the container by taking the items, before removing it, still crashes.

So it looks more like its the title of the container on the widget still in memory.
Once that is overriden by a second container, the crashing on save stops.

realmsandruins

Thanks for the follow up and investigation Slayer! This was an interesting one!

realmsandruins

It looks like this game breaking and save corrupting bug is still occurring as of 6/6/2024

realmsandruins

Justin Hey Justin! Whoops, looks like I may have accidentally deleted the original link. Here's a new barebones project I threw together real quick. I opened the chest, took the item, close the chest (which removes self on close script) then immediately save and the crash still happens. However, it's worth noting in my main project if you play for a while after opening the chest and it closes itself, the issue doesn't occur. It seems to need to be pretty immediate after the chest removes itself.

Slayer

Justin

it's actually not even to do with removing it while closing it.
If you simply remove a container that you've last used, and then save, it will crash.

. interact with a container
. close it
. aim mouse at it and type remove_entity(self)
. Save

All my investigations point to it being a container widget issue.

If you use a container and then remove it, and then immediately use a second container (set to the same widget for the container), it will save with no issues.
It's the fact that you have a container widget "in memory" that you have removed the object for, and then save.

If you remove the container object but then type "show_widget("item_container"); it will show the contents of the removed chest object...so it's still in memory, even if the model object is removed from the map.
Which is why if you interact with a second container model set to the same widget, it will override the one in memory with the new contents, and as long as you dont remove the second container, even though youve still removed the first, it will save.

Justin

realmsandruins Thanks so much for the example project! Those really save a lot of time and help take the guesswork out of reproducing the bugs, I really appreciate you providing them.

@Slayer Thanks for the additional info! Looks like you hit the nail on the head with it being a container widget issue, that helped a lot! As suggested, the container widget had a reference to an invalid entity since it had been removed, causing the crash when trying to store that in the save file.

I've fixed this for the next release so when using "Remove Entity" it will properly clear out that reference if it's a container object and is still connected to a widget. 👍